Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the duplicate usage flag value #1231

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Fix the duplicate usage flag value #1231

merged 6 commits into from
Jul 25, 2024

Conversation

ArcturusZhang
Copy link
Member

The Xml in UsageFlag accidentally to have a duplicate value with an existing one, this PR fixes it.

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Jul 24, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 24, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-autorest-canonical
  • ✅ @azure-tools/typespec-autorest
  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - breaking ✏️

refactor tcgc build-in types, please refer pr's description for details and migration guides

@azure-tools/typespec-client-generator-core - fix ✏️

fix the duplicate usageflags values for json and xml

@azure-tools/typespec-client-generator-core - feature ✏️

Support model format of @multipartBody

@azure-tools/typespec-client-generator-core - fix ✏️

have @clientName work for operation groups as well

@azure-tools/typespec-client-generator-core - fix ✏️

Fix @clientName conflict validation that operation defined within an interface

@azure-tools/typespec-client-generator-core - feature ✏️

add example types support

@azure-tools/typespec-autorest - internal ✏️

create tcgc context change to async

@azure-tools/typespec-autorest-canonical - internal ✏️

adopt tcgc breaking

@azure-tools/typespec-client-generator-core - feature ✏️

add xml usage and change enumvalue arg representation in generic decorators

@ArcturusZhang ArcturusZhang enabled auto-merge (squash) July 25, 2024 02:29
@ArcturusZhang ArcturusZhang enabled auto-merge (squash) July 25, 2024 02:41
@ArcturusZhang ArcturusZhang merged commit 01e5e0d into Azure:release/july-2024 Jul 25, 2024
20 of 22 checks passed
@ArcturusZhang ArcturusZhang deleted the fix-usage-issue branch July 25, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArcturusZhang @azure-sdk @tadelesh